Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable phpspec with Symfony 6 #34

Closed
wants to merge 1 commit into from
Closed

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Nov 3, 2021

@kbond
Copy link
Contributor Author

kbond commented Jan 12, 2022

I believe if you re-run these actions, it will pass.

@kbond kbond marked this pull request as ready for review January 12, 2022 00:06
@umpirsky
Copy link
Owner

Strangely enough I don't have option to rerun.

@kbond kbond force-pushed the phpspec-sf6 branch 2 times, most recently from e096137 to 72c175d Compare January 12, 2022 18:47
@kbond
Copy link
Contributor Author

kbond commented Jan 12, 2022

phpspec's now at least running but I'm not familiar enough with the tool to fix the failures.

@umpirsky
Copy link
Owner

It's better in kbond#1, but still have:

/bin/tools/phpspec/vendor/bin/phpspec ru      
Umpirsky/I18nRoutingBundle/Routing/Strategy/PrefixExceptDefaultStrategy           
  21  - it generates route collection one as is and one with locale prefixed route
      exception [err:TypeError("Double\Symfony\Component\Routing\Route\P3::getPath(): Return value must be of type string, null returned")] has been thrown.

Umpirsky/I18nRoutingBundle/Routing/Strategy/PrefixStrategy                      
  21  - it generates route collection with locale prefixed route
      exception [err:TypeError("Double\Symfony\Component\Routing\Route\P3::getPath(): Return value must be of type string, null returned")] has been thrown.

                         66%                                     33%             6
5 specs
6 examples (4 passed, 2 broken)
29ms

@umpirsky
Copy link
Owner

It highly depends on the version, so it's hard to cover all cases.

@kbond kbond closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants