-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate company CannotFindMatch
page to React Router
#7467
Open
cgsunkel
wants to merge
5
commits into
main
Choose a base branch
from
chore/move-cannot-find-match-page-to-rr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+166
−255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-hub-frontend Run #58747
Run Properties:
|
Project |
data-hub-frontend
|
Branch Review |
chore/move-cannot-find-match-page-to-rr
|
Run status |
Passed #58747
|
Run duration | 08m 30s |
Commit |
ea0a14bb34: Remove legacy code #2
|
Committer | Christopher |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
4
|
Skipped |
0
|
Passing |
74
|
View all changes introduced in this branch ↗︎ |
cgsunkel
force-pushed
the
chore/move-cannot-find-match-page-to-rr
branch
from
January 17, 2025 15:24
74edee4
to
7b50f77
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7467 +/- ##
==========================================
+ Coverage 88.60% 88.62% +0.01%
==========================================
Files 1150 1150
Lines 17951 17928 -23
Branches 5127 5127
==========================================
- Hits 15906 15889 -17
+ Misses 2045 2039 -6 ☔ View full report in Codecov by Sentry. |
cgsunkel
force-pushed
the
chore/move-cannot-find-match-page-to-rr
branch
from
January 20, 2025 16:48
aa4575d
to
ea0a14b
Compare
baarkerlounger
approved these changes
Jan 21, 2025
DeanElliott96
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The
CannotFindMatch
company page has been migrated to React Router. The submission task (which is currently still using Express) is now also in Redux.Test instructions
The company
CannotFindMatch
page should work as normal.Checklist