Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate company CannotFindMatch page to React Router #7467

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cgsunkel
Copy link
Contributor

@cgsunkel cgsunkel commented Jan 17, 2025

Description of change

The CannotFindMatch company page has been migrated to React Router. The submission task (which is currently still using Express) is now also in Redux.

Test instructions

The company CannotFindMatch page should work as normal.

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Jan 17, 2025

data-hub-frontend    Run #58747

Run Properties:  status check passed Passed #58747  •  git commit ea0a14bb34: Remove legacy code #2
Project data-hub-frontend
Branch Review chore/move-cannot-find-match-page-to-rr
Run status status check passed Passed #58747
Run duration 08m 30s
Commit git commit ea0a14bb34: Remove legacy code #2
Committer Christopher
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 74
View all changes introduced in this branch ↗︎

@cgsunkel cgsunkel force-pushed the chore/move-cannot-find-match-page-to-rr branch from 74edee4 to 7b50f77 Compare January 17, 2025 15:24
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.62%. Comparing base (d3b1615) to head (ea0a14b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/client/modules/Companies/MatchCompany/tasks.js 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7467      +/-   ##
==========================================
+ Coverage   88.60%   88.62%   +0.01%     
==========================================
  Files        1150     1150              
  Lines       17951    17928      -23     
  Branches     5127     5127              
==========================================
- Hits        15906    15889      -17     
+ Misses       2045     2039       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgsunkel cgsunkel force-pushed the chore/move-cannot-find-match-page-to-rr branch from aa4575d to ea0a14b Compare January 20, 2025 16:48
@cgsunkel cgsunkel marked this pull request as ready for review January 20, 2025 17:14
@cgsunkel cgsunkel requested a review from a team as a code owner January 20, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants