Add EYB leads page sort by filter #7465
Merged
+94
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Oliver Roberts <oliverjwroberts@gmail.com>
Co-authored-by: Oliver Roberts <oliverjwroberts@gmail.com>
data-hub-frontend
|
||||||||||||||||||||||||||||
| Project |
data-hub-frontend
|
| Branch Review |
feature/CLS2-928-add-eyb-sort-by-filter
|
| Run status |
|
| Run duration | 08m 10s |
| Commit |
|
| Committer | Oliver Roberts |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
4
|
Skipped
|
0
|
Passing
|
74
|
| View all changes introduced in this branch ↗︎ | |
ClaudiaGC1339
changed the title
For context, when visiting the index of a page which has default query parameters (and the index url does not contain these), the app makes a second request with those parameters. As a result, multiple requests were caught by the intercept. This commit changes the intercept statements for most tests to target a specific request which assertions can then be carried out on.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7465 +/- ##
==========================================
+ Coverage 88.54% 88.60% +0.05%
==========================================
Files 1152 1152
Lines 17963 17965 +2
Branches 5121 5122 +1
==========================================
+ Hits 15906 15918 +12
+ Misses 2057 2047 -10 ☔ View full report in Codecov by Sentry. |
DeanElliott96
approved these changes
Jan 21, 2025
marijnkampf
approved these changes
Jan 21, 2025
chopkinsmade
pushed a commit
that referenced
this pull request
Jan 21, 2025
…yb-sort-by-filter generated from commit f462e92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added a sort by dropdown filter to the EYB leads page. The filter sorts by most recently created and company name A-Z.
API part of the work: uktrade/data-hub-api#5896
Test instructions
Navigate to the EYB leads tab. The sort by filter should be visible above the leads collection list.
Screenshots
Before
After
Checklist