Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embed actual image version into os-release #2130

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

m2Giles
Copy link
Member

@m2Giles m2Giles commented Jan 9, 2025

No description provided.

Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
Copy link
Member Author

m2Giles commented Jan 16, 2025

@castrojo This also removes the Major Version. So this should get reported by Brew as Bluefin. In the parans, there will be the version with date string and stream, FROM Silverblue ${FEDORA_VERSION}.

@m2Giles m2Giles marked this pull request as ready for review January 16, 2025 01:03
@m2Giles m2Giles requested a review from castrojo as a code owner January 16, 2025 01:03
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Jan 16, 2025
# Added in systemd 249.
# https://www.freedesktop.org/software/systemd/man/latest/os-release.html#IMAGE_ID=
echo "IMAGE_ID=\"${IMAGE_NAME}\"" >> /usr/lib/os-release
echo "IMAGE_VERSION=\"${VERSION}\"" >> /usr/lib/os-releae
Copy link

@reyemxela reyemxela Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a typo on line 60, os-releae

@castrojo castrojo added this pull request to the merge queue Jan 16, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 16, 2025
Merged via the queue into main with commit 36c6eef Jan 16, 2025
34 checks passed
@castrojo castrojo deleted the osrelease-ver branch January 16, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants