Add the uap-core test suite #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Jacobs <atheriel@gmail.com>
Note that this does not stage the test case YAML files themselves, although the code expects them to be present. This commit does not add the device tests, since the package does not really support them. Signed-off-by: Aaron Jacobs <atheriel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the means to run the test suite from uap-core using the testthat package. Note that this does not stage the (very large) test case YAML files themselves, although the test code expects them to be present. I can add some code to download them automatically if they are missing, if this is desirable.
Many of the tests are failing. And the suite takes a surprising amount of time to run (in the order of an hour) on my machine, although this may be related to my ow boost/std::regex surgery. However, I still think there is value in having them.
This PR does not add the device tests, since the package does not really support parsing them anyway.