Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split 'munit' and 'munit-scalacheck' versions #326

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

satorg
Copy link
Contributor

@satorg satorg commented Dec 31, 2024

  1. Splits munit and munit-scalacheck versions since these they have to be tracked separately;
  2. Extracts Scala versions into vals in order to reduce conflicts on project updates.

extract Scala versions into vals
@satorg satorg self-assigned this Dec 31, 2024
@satorg satorg requested a review from TonioGela December 31, 2024 21:00
@satorg
Copy link
Contributor Author

satorg commented Jan 10, 2025

I'd probably go merge these changes even without approvals, since they are pretty straightforward.

Unless there will be any concerns or objections emerged within the next few days.
@TonioGela , wdyt?

@TonioGela
Copy link
Member

I'd probably go merge these changes even without approvals, since they are pretty straightforward.

Unless there will be any concerns or objections emerged within the next few days. @TonioGela , wdyt?

No problem at all, go for it @satorg

@satorg satorg merged commit 90f20cb into typelevel:main Jan 12, 2025
11 checks passed
@satorg satorg deleted the split-munit-scalacheck branch January 12, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants