various not push related notification improvements #4929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationService.kt
Tak
approved these changes
Feb 24, 2025
| val b = bodyForType(body, account) | ||
|
|
||
| Log.d(TAG, "titleForType: $t") | ||
| Log.d(TAG, "bodyForType: $b") |
There was a problem hiding this comment.
nope this was debugging to see why no body was shown 🤦
| <string name="moderation_warning_action_silence">Your account has been limited.</string> | ||
| <string name="moderation_warning_action_suspend">Your account has been suspended.</string> | ||
|
|
||
| <string name="unknown_notification_type_explanation">Tusky does not recognize this notification type and can\'t show it to you. Your server\'s web interface may be able to do so. Please also inform the Tusky developers so they can add support for this type! </string> |
There was a problem hiding this comment.
Maybe "instance" instead of "server"? 🤷
There was a problem hiding this comment.
I don't really care, I used server because I think thats what Mastodon calls them these days.
There was a problem hiding this comment.
True. Now "server" is offcial and it's better understand in other languages.
connyduck
added a commit
that referenced
this pull request
Feb 28, 2025
This changes the notification channel names back to what they were pre #4929 so users don't lose their settings and the channels won't be duplicated. Tusky nightly users that installed a in-between version will still have duplicate channels, they will need to reinstall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
severed_relationships, closes Unknown Notification Type - severed relationship #4835, closes Support new notification type "severed_relationships" #4334moderation_warning<user>just posted" notification is now a bell instead of a homeSome screenshots:
