Fix (btree) clear_overflow_page
#971
Open
+157
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pereman2
requested changes
Feb 12, 2025
core/storage/btree.rs
Outdated
Comment on lines
2751
to
2773
| log::info!( | ||
| "After inserts:\n{}", | ||
| format_btree(pager.clone(), root_page, 0) | ||
| ); |
There was a problem hiding this comment.
This should probably be lower log level like trace.
core/storage/btree.rs
Outdated
| for &(key, size, _) in sequence.iter() { | ||
| let key = OwnedValue::Integer(key); | ||
| let value = Record::new(vec![OwnedValue::Blob(Rc::new(vec![0; size]))]); | ||
| log::info!("Inserting key: {}", key); |
SQLite does floor division but clippy erroneously says its floor division. Ignore clippy warning.
The previous version when tested with large blobs was breaking invariants.
Added large blobs to try and break delete.
krishvishal
force-pushed
the
fix-clear-overflow-page
branch
from
d786340 to
a1143f7
Compare
|
@pereman2 I've added the requested changes. The reason for this PR: When I have added the fuzz test it has triggered some asserts in the |
pereman2
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs in
clear_overflow_pageimplementation.