-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for VALUES
statement
#1049
base: main
Are you sure you want to change the base?
Conversation
I can't reproduce the failing fuzz test on my local machine. The failure seems to be related to how string concatenation is handled in limbo and unrelated to the current PR. I will look into it in a separate PR. |
@krishvishal have a look at #1021 and #1038 to see your particular error is fixed there. I am trying to fix some text_casts and @jussisaurio was trying to fix a whole lot more in his. |
…SQLite compability.
Add more tests
@pedrocarlo thanks for sharing this. |
61d0c9e
to
66f8f5b
Compare
@penberg requesting review. |
}); | ||
|
||
if let ast::OneSelect::Values(values) = &select.body.select.as_ref() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we shouldn't need separate specialcasing to handle this. What about e.g. SELECT * from sometable JOIN (VALUES (1),(2),(3))?
It seems VALUES
with multiple rows is quite similar to how subqueries work.
VALUES
statement.VALUES
statement
Current:
After this PR:
Fixes: #866