-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moodle Plugin CI, and Moodle coding style #728
base: develop
Are you sure you want to change the base?
Conversation
28309a9
to
c4ce6ce
Compare
Thanks very much for this PR, we should definitely be following the Moodle style guides. |
I can understand very well. Please refer to #731 where the same code lies but with the omission of Github workflows. |
b1f755c
to
63b9aba
Compare
e76b410
to
1bcaabe
Compare
4e1e921
to
bb20dd8
Compare
Release v2024120501
Release v2024121901
bb20dd8
to
b0c27b4
Compare
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
b42fd89
to
e0648eb
Compare
e0648eb
to
29c3d1f
Compare
29c3d1f
to
305e23e
Compare
In these commits, I wanted to prove that the plagiarism_turnitin plugin could well be rewritten/reformatted to adhere to Moodle coding guidelines.
The submitted did not completely fix PHPUnit and Behat tests, though.
Thanks for taking into consideration. If desired, I can also divide into smaller pieces, of course.