Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moodle Plugin CI, and Moodle coding style #728

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

lucaboesch
Copy link
Contributor

@lucaboesch lucaboesch commented Jul 26, 2024

In these commits, I wanted to prove that the plagiarism_turnitin plugin could well be rewritten/reformatted to adhere to Moodle coding guidelines.
The submitted did not completely fix PHPUnit and Behat tests, though.

Thanks for taking into consideration. If desired, I can also divide into smaller pieces, of course.

@jack-tii
Copy link
Contributor

jack-tii commented Jul 29, 2024

Thanks very much for this PR, we should definitely be following the Moodle style guides.
We are currently having internal discussions about how best to add Github workflows to our plugins as described in https://moodlehq.github.io/moodle-plugin-ci/
Merging this would therefore have to wait until after our next TT release, which is currently planned for August 1st. I will keep you updated regarding our decisions around this, as this is a feature I would love to have.

@lucaboesch
Copy link
Contributor Author

I can understand very well. Please refer to #731 where the same code lies but with the omission of Github workflows.

@lucaboesch lucaboesch force-pushed the codingstylefixes branch 2 times, most recently from e76b410 to 1bcaabe Compare August 15, 2024 07:17
@lucaboesch lucaboesch force-pushed the codingstylefixes branch 2 times, most recently from 4e1e921 to bb20dd8 Compare August 22, 2024 05:19
Copy link

snyk-io bot commented Dec 20, 2024

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@lucaboesch lucaboesch force-pushed the codingstylefixes branch 6 times, most recently from b42fd89 to e0648eb Compare December 21, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants