Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pair_coalescence_counts method #2920

Closed
wants to merge 2 commits into from

Conversation

nspope
Copy link
Contributor

@nspope nspope commented Apr 10, 2024

Reprise of #2915

Copy link
Contributor

mergify bot commented Apr 10, 2024

⚠️ The sha of the head commit of this PR conflicts with #2915. Mergify cannot evaluate rules on this PR. ⚠️

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0.72464% with 137 lines in your changes are missing coverage. Please review.

Project coverage is 81.60%. Comparing base (045b419) to head (77bbe72).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2920      +/-   ##
==========================================
+ Coverage   81.31%   81.60%   +0.29%     
==========================================
  Files          48       48              
  Lines       37856    37426     -430     
  Branches     7295     7232      -63     
==========================================
- Hits        30782    30542     -240     
+ Misses       5653     5466     -187     
+ Partials     1421     1418       -3     
Flag Coverage Δ
c-tests 86.21% <ø> (ø)
lwt-tests 80.78% <ø> (ø)
python-c-tests 68.45% <0.72%> (+0.74%) ⬆️
python-tests 98.97% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/tskit/stats.py 35.13% <ø> (+24.79%) ⬆️
python/tskit/trees.py 43.88% <0.72%> (-2.75%) ⬇️

... and 2 files with indirect coverage changes

@jeromekelleher
Copy link
Member

@benjeffery any idea what's going on with codecov here?

@jeromekelleher
Copy link
Member

Would it help to merge a small PR which doesn't do much to try and reset codecov's view of HEAD?

@nspope
Copy link
Contributor Author

nspope commented Apr 10, 2024

The Codecov uploads are failing with:

[2024-04-10T04:25:12.526Z] ['verbose'] The error stack is: Error: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

Looks like this has been cropping up elsewhere? In particular, with PRs coming from forked repos.

@nspope
Copy link
Contributor Author

nspope commented Apr 10, 2024

FWIW it sounds like bumping the codecov-action version from 3 to 4 may fix the issue:

uses: codecov/codecov-action@v3

there's a blurb in the v4 notes here,

v3 versions and below will not have access to CLI features (e.g. global upload token, ATS).

@benjeffery
Copy link
Member

FWIW it sounds like bumping the codecov-action version from 3 to 4 may fix the issue:

uses: codecov/codecov-action@v3

there's a blurb in the v4 notes here,

v3 versions and below will not have access to CLI features (e.g. global upload token, ATS).

Will try that - thanks for the pointer.

nspope added 2 commits April 10, 2024 17:19
…tion

Add test against worked example

Remove unused imports

More efficient windowing

Raise errors with invalid inputs

Misc. fixes and tests; add time discretisation argument

Test nonsuccinct case

Fix negative times for time windows

Delete accidental line copy

Remove unneeded if
@nspope nspope force-pushed the pair-coalescence-counts-python branch from b431c6a to 77bbe72 Compare April 11, 2024 00:19
@nspope nspope mentioned this pull request Apr 11, 2024
@nspope
Copy link
Contributor Author

nspope commented Apr 18, 2024

Closing in favor of #2915

@nspope nspope closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants