Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simple test fixture for cli and tsci init test #22

Merged
merged 3 commits into from
Jan 16, 2025
Merged

feat: simple test fixture for cli and tsci init test #22

merged 3 commits into from
Jan 16, 2025

Conversation

kom-senapati
Copy link
Contributor

/claim #20

image

@algora-pbc algora-pbc bot mentioned this pull request Jan 13, 2025
Closed
imrishabh18
imrishabh18 reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@imrishabh18 imrishabh18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

seveibar
seveibar requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change and you're good to go, nice job!!!

tests/test2-cli-init.test.ts Outdated Show resolved Hide resolved
seveibar
seveibar approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very, very nice

@seveibar seveibar merged commit 58ce2e0 into tscircuit:main Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrishabh18 imrishabh18 imrishabh18 left review comments

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kom-senapati @seveibar @imrishabh18