Correct parquet row group pruning logic #25186
Merged
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
commented
Feb 28, 2025
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergParquetConnectorTest.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/metadata/ParquetMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergParquetConnectorTest.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/metadata/ParquetMetadata.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/metadata/ParquetMetadata.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
fix_parquet
branch
2 times, most recently
from
8546c4c to
60553c3
Compare
lib/trino-parquet/src/test/java/io/trino/parquet/writer/TestParquetWriter.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/metadata/ParquetMetadata.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/metadata/BlockMetadata.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
fix_parquet
branch
from
60553c3 to
5e7116a
Compare
When filtering row groups based on split boundaries in `ParquetMetadata.getBlocks()`, we need to maintain an accurate cumulative row count even for skipped row groups
chenjian2664
force-pushed
the
fix_parquet
branch
from
5e7116a to
b45386d
Compare
jinyangli34
approved these changes
Feb 28, 2025
raunaqmorarka
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #25151
I found the logic for pruning in 2ef6dc1c94 has correctness issue which caused the problems raised in
#25151
The reason is when rowGroup is skipped, the fileRowCount in
PredicateUtilscan not be updated correctly,this pr add the
fileRowCountOffsetintoBlockMetadatato correctly hold this semantic of data.Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: