-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal tarball #25026
base: master
Are you sure you want to change the base?
Add minimal tarball #25026
Conversation
Test failure is a false alarm. I tested the tarball locally and it works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really like to see a second Docker image built from this, but I can do it as a follow-up.
Thats the plan .. just doing one step at a time. I will also need to doc out to create a custom tarball and how to add plugins to it.. all coming up. Would love your help on the docker container as well .. |
For Docker, we should do that as part of the main Docker build. Have a core image, then add additional plugins on top. This lets the core image be reused. |
Yes ... but I will tackle that later.. |
da89291
to
5a2342c
Compare
- Reuse new module as core for default tarball - Avoid duplication of artifact set definitions
Description
Creating a minimal tarball as alternative starting point for installation. It is used as base for the normal default tarball.
Main input from reviewers I need is .. which plugins should be in the core package? Currently adding some I consider more core but maybe even including none is a good idea. It depends a bit on what we do beyond this change.
Additional context and related issues
Relies on plugin docs in #25017 and further work in the docs
Part of #22597
Follow up in #25124
Enables further custom tarball creation see in trinodb/trino-packages#2
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: