Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal tarball #25026

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add minimal tarball #25026

wants to merge 2 commits into from

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Feb 14, 2025

Description

Creating a minimal tarball as alternative starting point for installation. It is used as base for the normal default tarball.

Main input from reviewers I need is .. which plugins should be in the core package? Currently adding some I consider more core but maybe even including none is a good idea. It depends a bit on what we do beyond this change.

Additional context and related issues

Relies on plugin docs in #25017 and further work in the docs

Part of #22597

Follow up in #25124

Enables further custom tarball creation see in trinodb/trino-packages#2

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## General

* TBD. ({issue}`22597`)

@mosabua
Copy link
Member Author

mosabua commented Feb 14, 2025

Test failure is a false alarm. I tested the tarball locally and it works fine.

Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really like to see a second Docker image built from this, but I can do it as a follow-up.

@mosabua
Copy link
Member Author

mosabua commented Feb 17, 2025

I'd really like to see a second Docker image built from this, but I can do it as a follow-up.

Thats the plan .. just doing one step at a time. I will also need to doc out to create a custom tarball and how to add plugins to it.. all coming up. Would love your help on the docker container as well ..

@electrum
Copy link
Member

For Docker, we should do that as part of the main Docker build. Have a core image, then add additional plugins on top. This lets the core image be reused.

@mosabua
Copy link
Member Author

mosabua commented Feb 19, 2025

For Docker, we should do that as part of the main Docker build. Have a core image, then add additional plugins on top. This lets the core image be reused.

Yes ... but I will tackle that later..

@mosabua mosabua marked this pull request as ready for review February 21, 2025 21:35
@github-actions github-actions bot added the docs label Feb 21, 2025
@mosabua mosabua changed the title Add minimal tarball trino-server-core Improve packaging Feb 21, 2025
@mosabua mosabua force-pushed the tarcore branch 3 times, most recently from da89291 to 5a2342c Compare February 22, 2025 00:42
@mosabua mosabua mentioned this pull request Feb 24, 2025
@mosabua mosabua changed the title Improve packaging Add minimal tarball Feb 24, 2025
- Reuse new module as core for default tarball
- Avoid duplication of artifact set definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants