Add 'release-debug' build type (#3633) and change some 'waterman' builds (#3336) #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow many of the ATDM Trilinos 'debug' builds to be switched to 'release-debug' builds and help to avoid a bunch of timeouts that we are dealing with.
…rilinos#3633) I kept the existing cuda-9.2-debug-Power9-Volta70 build since there are currently not any timing out tests in that build and I figured that the CUDA build was most likey the one a developer would want to run with a debugger. But I created a new cuda-9.2-release-debug-Power9-Volta70 build so that we can avoid having to disable slow Kokkos, KokkosKernels, and other tests that run super slow with -O0. I changed the build gnu-debug-openmp-Power9-Volta70 to a gnu-release-debug-openmp-Power9-Volta70 build since I don't think it is as important to run this build with a debugger and the full 'debug' build and this build currently has some timing-out tests for Kokkos and KokkosKernals as described in trilinos#3336. (The new gnu-release-debug-openmp-Power9-Volta70 build has not have any timeouts.) If the APP teams tell us they want a full gnu-debug-openmp-Power9-Volta70 build, then we will add one back and deal with the timeouts. NOTE: By having both 'debug' and 'release-debug' builds, we can be free to disable some slow tests in the full 'debug' build and not loose much runtime debug checking since these tests will be running in the 'release-debug' build (with runtime debug checking enabled). So going forward, if a test times-out in the 'debug' build but not the 'release-debug' build, then we will just disable it in the 'debug' build and move on. I also renamed the 'cuda' builds to 'cuda-9.2' builds since that is what they are and that matches the Jenkins drive names.
bartlettroscoe
added
pkg: Kokkos
pkg: KokkosKernels
client: ATDM
bartlettroscoe
added
stage: in progress
bartlettroscoe
added
the
AT: AUTOMERGE
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
ibaned
approved these changes
Oct 18, 2018
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ibaned ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 3659: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
|
Thanks @ibaned ! |
bartlettroscoe
added a commit
to bartlettroscoe/Trilinos
that referenced
this pull request
Oct 18, 2018
…terman' cuda-9.2-debug build (trilinos#3336) Now that this test is running and passing in the new build Trilinos-atdm-waterman-cuda-9.2-release-debug (see trilinos#3659 and trilinos#3633), it is fine to disable this in this full -O3 build. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # On branch 3336-waterman-disable-kokkoscontainers-test # Changes to be committed: # modified: cmake/std/atdm/waterman/tweaks/CUDA-9.2-DEBUG-CUDA-POWER9-VOLTA70.cmake #
bartlettroscoe
added a commit
to bartlettroscoe/Trilinos
that referenced
this pull request
Oct 18, 2018
…terman' cuda-9.2-debug build (trilinos#3336) Now that this test is running and passing in the new build Trilinos-atdm-waterman-cuda-9.2-release-debug (see trilinos#3659 and trilinos#3633), it is fine to disable this in this full -O3 build.
1 task
bartlettroscoe
added
ATDM DevOps
tjfulle
pushed a commit
to tjfulle/Trilinos
that referenced
this pull request
Dec 6, 2018
…terman' cuda-9.2-debug build (trilinos#3336) Now that this test is running and passing in the new build Trilinos-atdm-waterman-cuda-9.2-release-debug (see trilinos#3659 and trilinos#3633), it is fine to disable this in this full -O3 build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @fryeguy52
Description
This will allow many of the ATDM Trilinos 'debug' builds to be switched to
'release-debug' builds and help to avoid a bunch of timeouts that we are
dealing with.
Switch some 'waterman' 'debug' builds to new 'release-debug' builds (#3633)
I kept the existing cuda-9.2-debug-Power9-Volta70 build since there are
currently not any timing out tests in that build and I figured that the CUDA
build was most likey the one a developer would want to run with a debugger.
But I created a new cuda-9.2-release-debug-Power9-Volta70 build so that we can
avoid having to disable slow Kokkos, KokkosKernels, and other tests that run
super slow with -O0.
I changed the build gnu-debug-openmp-Power9-Volta70 to a
gnu-release-debug-openmp-Power9-Volta70 build since I don't think it is as
important to run this build with a debugger and the full 'debug' build and
this build currently has some timing-out tests for Kokkos and KokkosKernals as
described in #3336. (The new gnu-release-debug-openmp-Power9-Volta70 build
has not have any timeouts.) If the APP teams tell us they want a full
gnu-debug-openmp-Power9-Volta70 build, then we will add one back and deal with
the timeouts.
NOTE: By having both 'debug' and 'release-debug' builds, we can be free to
disable some slow tests in the full 'debug' build and not loose much runtime
debug checking since these tests will be running in the 'release-debug' build
(with runtime debug checking enabled). So going forward, if a test times-out
in the 'debug' build but not the 'release-debug' build, then we will just
disable it in the 'debug' build and move on.
I also renamed the 'cuda' builds to 'cuda-9.2' builds since that is what they
are and that matches the Jenkins drive names.
Motivation and Context
We want to avoid timeouts like #3336 recently and going forward (see #3633).
How Has This Been Tested?
I tested this on on 'waterman' with:
and it returned:
NOTE: The timing-out tests
KokkosContainers_UnitTest_Serial_MPI_1andKokkosKernels_graph_serial_MPI_1for the updated buildgnu-release-debug-openmp-Power9-Volta70(which used to be the full debug buildgnu-debug-openmp-Power9-Volta70) reported in #3336 are gone! For the buildgnu-release-debug-openmp-Power9-Volta70the ctest output showed:So merging this branch will fix #3336.
Checklist