Cardano + tokens issues #16459
Open
Cardano + tokens issues #16459
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytick
changed the title
Nodonisko
reviewed
Jan 18, 2025
| @@ -185,7 +186,11 @@ export const selectTokenDefinitionsEnabledNetworks = createMemoizedSelector( | |||
| [selectEnabledDiscoveryNetworkSymbols, selectNetworkSymbolsOfAccountsWithTokensAllowed], | |||
| (enabledNetworkSymbols, accountNetworkSymbols) => | |||
| returnStableArrayIfEmpty( | |||
| F.toMutable(A.uniq([...enabledNetworkSymbols, ...accountNetworkSymbols])), | |||
| F.toMutable( | |||
| A.uniq([...enabledNetworkSymbols, ...accountNetworkSymbols]).filter(s => | |||
There was a problem hiding this comment.
Please use pipe and ideally move filter before uniq
Nodonisko
reviewed
Jan 18, 2025
|
|
||
| const knownTokens = useSelector((state: TokenDefinitionsRootState) => | ||
| selectFilterKnownTokens(state, symbol, accountInfo.tokens ?? []), | ||
| canHaveTokens ? selectFilterKnownTokens(state, symbol, accountInfo.tokens ?? []) : [], |
There was a problem hiding this comment.
would this just return empty array even without condition?
|
🚀 Expo preview is ready!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a6eedc8 count fiat balance for cardano tokens after decimals are applied
3aa329a dont fetch token definitions for not enabled networks and dont show them in this case
Related Issue
Resolve #16423
Resolve #16410
Screenshots:
BEFORE:
AFTER:
