chore: BigNumber.toString(10) to prevent output as exponential

[martykan]

Description

This change ensures that all toString calls on BigNumber objects include base 10 as a parameter. By doing this, we prevent numbers from being displayed in exponential form.

• added unit and e2e test for ETH staking with balances >= 1000 ETH

[tomasklim]

I am worried that someone will forget to add 10 and the same issue will occur again later.

It is now already missing in e.g. blockfrost.ts

Can we modify the BigNumber config to a really big number?

BigNumber.config({ EXPONENTIAL_AT: 1e+50 });

or modify toString prototype to have base=10 by default?

const originalToString = BigNumber.prototype.toString;

BigNumber.prototype.toString = (base = 10) => originalToString.call(this, base);

[martykan]

Yeah, it's true that this is not that maintainable. My idea to solve this was by making an Eslint plugin, since I already have a script which I used to make these changes.

But based on your ideas, I think the best solution would probably be to create a new wrapper package which we would import instead of BigNumber, there would use BigNumber.clone() to create our instance and set the config on it. Or override the prototype.

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source
Filesystem access	npm/resolve-from@5.0.0	Module: fs Location: Package overview	Source
Filesystem access	npm/argparse@2.0.1	Module: fs Location: Package overview	Source
Filesystem access	npm/glob@7.2.3	Module: fs Location: Package overview	Source
Filesystem access	npm/glob@7.2.3	Module: fs.realpath Location: Package overview	Source
New author	npm/ms@2.1.2	New Author: styfle Previous Author: leo	Source
Uses eval	npm/ajv@6.12.6	Eval Type: Function Location: Package overview	Source
Trivial Package	npm/escape-string-regexp@1.0.5	Location: Package overview	Source
Filesystem access	npm/fs.realpath@1.0.0	Module: fs Location: Package overview	Source
Filesystem access	npm/resolve-from@4.0.0	Module: fs Location: Package overview	orphan: npm/resolve-from@4.0.0
Filesystem access	npm/chardet@0.7.0	Module: fs Location: Package overview	Source
Filesystem access	npm/graceful-fs@4.2.11	Module: fs Location: Package overview	Source
New author	npm/istanbul-lib-source-maps@4.0.1	New Author: oss-bot Previous Author: coreyfarrell	Source
Filesystem access	npm/istanbul-lib-source-maps@4.0.1	Module: fs Location: Package overview	Source
New author	npm/babel-plugin-istanbul@6.1.1	New Author: oss-bot Previous Author: coreyfarrell	Source
Filesystem access	npm/babel-plugin-istanbul@6.1.1	Module: fs Location: Package overview	Source
Shell access	npm/babel-plugin-istanbul@6.1.1	Module: child_process Location: Package overview	Source
New author	npm/convert-source-map@2.0.0	New Author: phated Previous Author: thlorenz	Source
Filesystem access	npm/get-package-type@0.1.0	Module: fs Location: Package overview	Source
Shell access	npm/cross-spawn@7.0.3	Module: child_process Location: Package overview	Source
Filesystem access	npm/cross-spawn@7.0.3	Module: fs Location: Package overview	Source
New author	npm/merge-stream@2.0.0	New Author: stevemao Previous Author: shinnn	orphan: npm/merge-stream@2.0.0
Filesystem access	npm/isexe@2.0.0	Module: fs Location: Package overview	orphan: npm/isexe@2.0.0
New author	npm/@babel/plugin-syntax-import-meta@7.10.4	New Author: jlhwung Previous Author: nicolo-ribaudo	Source
New author	npm/@babel/plugin-syntax-logical-assignment-operators@7.10.4	New Author: jlhwung Previous Author: nicolo-ribaudo	Source
New author	npm/@babel/plugin-syntax-numeric-separator@7.10.4	New Author: jlhwung Previous Author: nicolo-ribaudo	Source
New author	npm/anymatch@3.1.3	New Author: phated Previous Author: paulmillr	Source
New author	npm/fb-watchman@2.0.2	New Author: bolinfest Previous Author: wez	Source
Network access	npm/fb-watchman@2.0.2	Module: net Location: Package overview	Source
Shell access	npm/fb-watchman@2.0.2	Module: child_process Location: Package overview	Source
Filesystem access	npm/argparse@1.0.10	Module: fs Location: Package overview	orphan: npm/argparse@1.0.10
Filesystem access	npm/is-docker@2.2.1	Module: fs Location: Package overview	Source
Trivial Package	npm/is-arrayish@0.2.1	Location: Package overview	Source
New author	npm/kind-of@6.0.3	New Author: doowb Previous Author: jonschlinkert	Source
Filesystem access	npm/debug@2.6.9	Module: fs Location: Package overview	orphan: npm/debug@2.6.9
Network access	npm/debug@2.6.9	Module: net Location: Package overview	orphan: npm/debug@2.6.9
Uses eval	npm/bluebird@3.7.2	Eval Type: Function Location: Package overview	Source
Uses eval	npm/bluebird@3.7.2	Eval Type: Function Location: Package overview	Source
Uses eval	npm/bluebird@3.7.2	Eval Type: Function Location: Package overview	Source
Uses eval	npm/bluebird@3.7.2	Eval Type: Function Location: Package overview	Source
Uses eval	npm/bluebird@3.7.2	Eval Type: Function Location: Package overview	Source
Uses eval	npm/bluebird@3.7.2	Eval Type: Function Location: Package overview	Source
Uses eval	npm/bluebird@3.7.2	Eval Type: eval Location: Package overview	Source
Network access	npm/https-proxy-agent@5.0.1	Module: net Location: Package overview	Source
Network access	npm/https-proxy-agent@5.0.1	Module: tls Location: Package overview	Source
Filesystem access	npm/@nodelib/fs.stat@2.0.5	Module: fs Location: Package overview	Source
Filesystem access	npm/@nodelib/fs.scandir@2.1.5	Module: fs Location: Package overview	Source
Trivial Package	npm/at-least-node@1.0.0	Location: Package overview	Source
Filesystem access	npm/path-type@4.0.0	Module: fs Location: Package overview	Source
Trivial Package	npm/isarray@2.0.5	Location: Package overview	Source
Filesystem access	npm/escalade@3.1.1	Module: fs Location: Package overview	Source
Filesystem access	npm/require-directory@2.1.1	Module: fs Location: Package overview	orphan: npm/require-directory@2.1.1
Filesystem access	npm/readdirp@3.6.0	Module: fs Location: Package overview	Source
Network access	npm/methods@1.1.2	Module: http Location: Package overview	Source
Filesystem access	npm/chownr@2.0.0	Module: fs Location: Package overview	Source
Network access	npm/http-proxy-agent@5.0.0	Module: net Location: Package overview	Source
Network access	npm/http-proxy-agent@5.0.0	Module: tls Location: Package overview	Source
New author	npm/for-each@0.3.3	New Author: ljharb Previous Author: raynos	orphan: npm/for-each@0.3.3
Filesystem access	npm/loader-runner@4.3.0	Module: fs Location: Package overview	orphan: npm/loader-runner@4.3.0
Uses eval	npm/loader-runner@4.3.0	Eval Type: eval Location: Package overview	orphan: npm/loader-runner@4.3.0
Filesystem access	npm/glob@7.1.6	Module: fs Location: Package overview	orphan: npm/glob@7.1.6
Filesystem access	npm/glob@7.1.6	Module: fs.realpath Location: Package overview	orphan: npm/glob@7.1.6
Floating dependency	npm/@types/eslint-scope@3.7.4	Location: Package overview	orphan: npm/@types/eslint-scope@3.7.4
Floating dependency	npm/@types/eslint-scope@3.7.4	Location: Package overview	orphan: npm/@types/eslint-scope@3.7.4
Floating dependency	npm/@types/jsdom@20.0.1	Location: Package overview	Source
Floating dependency

[MiroslavProchazka]

@Nodonisko @mroz22 can you please do the final review and approve/add comment? Thanks!