-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(suite): haptic-feedback settings #12323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
force-pushed
the
haptic-settings
branch
from
May 9, 2024 10:36
d3054a1
to
022c3e9
Compare
peter-sanderson
commented
May 9, 2024
@@ -67,6 +67,7 @@ export enum EventType { | |||
SettingsDeviceChangeLabel = 'settings/device/change-label', | |||
SettingsDeviceUpdateAutoLock = 'settings/device/update-auto-lock', | |||
SettingsDeviceChangeOrientation = 'settings/device/change-orientation', | |||
SettingsDeviceChangeHapticFeedback = 'settings/device/change-haptic-feedback', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add it to Notion docs for analytics
peter-sanderson
force-pushed
the
haptic-settings
branch
from
May 13, 2024 15:23
022c3e9
to
c6f4b3e
Compare
Hannsek
reviewed
May 16, 2024
peter-sanderson
force-pushed
the
haptic-settings
branch
4 times, most recently
from
May 20, 2024 10:17
c406c0f
to
d4439e8
Compare
peter-sanderson
force-pushed
the
haptic-settings
branch
5 times, most recently
from
June 5, 2024 11:18
0abfb9b
to
14bf6b8
Compare
peter-sanderson
requested review from
MiroslavProchazka,
tomasklim,
szymonlesisz and
martykan
as code owners
June 5, 2024 11:19
peter-sanderson
force-pushed
the
haptic-settings
branch
from
June 5, 2024 11:20
14bf6b8
to
547aff0
Compare
peter-sanderson
commented
Jun 5, 2024
mroz22
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
peter-sanderson
force-pushed
the
haptic-settings
branch
from
June 6, 2024 06:58
547aff0
to
0ec38bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve #12314 and #12442
Screenshots: