Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: 2.0-2.3 post draft #3370
website: 2.0-2.3 post draft #3370
Changes from 3 commits
82dd179
1b93564
fdf0e91
e26f483
fde0909
f400a28
82b1f1c
b8bc65e
35706c2
e8385fc
5fc207e
e88b2da
28d4789
3e6943d
c2bcdd4
ee57003
00cf171
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure the prod API keys are in hosted companion before releasing this post
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could delay the post, if the keys are already available, then yes. Can we make sure Unsplash is on uppy.io and API2 soon, @mifi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The keys are already available yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For api2, I'm thinking that because we have quite big changes (not breaking but potentially bug-introducing) from #3159 we may want to test it first on uppy.io
For uppy.io, I still haven't had time to look into this #3362
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But do we need to upgrade Companion to enable Unsplash? I think that code has already been there quite a while, so we could just add keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some changes in companion related to Unsplash in /~https://github.com/transloadit/uppy/pull/3196/files on 1st october. I'm not sure if those companion changes are needed for the new unsplash frontend to work @Murderlon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are definitely needed yes.