Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Localisation manager filter. #922

Open
wants to merge 1 commit into
base: 7
Choose a base branch
from

Conversation

mfendeksilverstripe
Copy link
Contributor

@mfendeksilverstripe mfendeksilverstripe commented Jan 21, 2025

Description

Enables filtering capability in the localisation manager. This filter wasn't present because pre CMS 5 such feature was not supported. With CMS 5 it's possible so we should enable it.

Screenshot 2025-01-22 at 12 51 51 PM

Manual testing steps

  • Navigate to the localisation manager on any localised model and confirm that the filter is working from scaffolded fields

Issues

#924

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@tractorcow
Copy link
Collaborator

tractorcow commented Jan 22, 2025

Looks good to me. Generally the locales list isn't large enough that a search is required, but it's no harm to have it working. :)

@mfendeksilverstripe mfendeksilverstripe force-pushed the feature/localisation-manager-filter branch from bf62b3b to 1159c29 Compare January 22, 2025 02:09
@mfendeksilverstripe
Copy link
Contributor Author

FYI: Squashed commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants