Add hash/eq/neq for Standard_Transient and its derivatives #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR implements hash, equality, and inequality operators for Standard_Transient and its derivatives, along with code formatting improvements. The changes primarily focus on adding Python special methods (eq, ne, hash) to enable proper comparison and hashing of objects, while also cleaning up code indentation across multiple files. Class diagram for Standard_Transient and its derivativesclassDiagram
class Standard_Transient {
+__eq__(right)
+__ne__(right)
+__hash__()
+__eq_wrapper__(other)
+__ne_wrapper__(other)
}
class Standard_GUID {
+friend struct std::hash
}
class TDF_Label {
+friend struct std::hash
}
class XCAFPrs_Style {
+friend struct std::hash
}
note for Standard_Transient "Added Python special methods for comparison and hashing"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](/~https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @tpaviot - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| # Create a shape that differs from shape_2, but has the same TShape | ||
| shape_3 = shape_2.Reversed() | ||
| assert hash(shape_1.TShape()) == hash(shape_1.TShape()) | ||
| assert not hash(shape_1.TShape()) == hash(shape_2.TShape()) |
There was a problem hiding this comment.
suggestion (code-quality): Simplify logical expression using De Morgan identities (de-morgan)
Suggested change
| assert not hash(shape_1.TShape()) == hash(shape_2.TShape()) | |
| assert hash(shape_1.TShape()) != hash(shape_2.TShape()) |
Comment on lines
+558
to
+560
| assert not shape_1.TShape() == shape_2.TShape() | ||
| assert shape_2.TShape() == shape_3.TShape() | ||
| assert not shape_1.TShape() == "some_string" |
There was a problem hiding this comment.
issue (code-quality): Simplify logical expression using De Morgan identities [×2] (de-morgan)
Comment on lines
+568
to
+570
| assert not shape_1.TShape() != shape_1.TShape() | ||
| assert shape_1.TShape() != shape_2.TShape() | ||
| assert not shape_2.TShape() != shape_3.TShape() |
There was a problem hiding this comment.
issue (code-quality): Simplify logical expression using De Morgan identities [×2] (de-morgan)
|
see the related commit at pythonocc-generator tpaviot/pythonocc-generator@e8e3cbf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and a couple other minor fixes
based on #1375
Summary by Sourcery
Add hash, equality, and inequality operators for Standard_Transient and its derivatives, enhancing object comparison capabilities. Refactor existing operator implementations for improved readability. Include new tests to verify the functionality of these operators.
New Features:
Enhancements:
Tests: