Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generators): update app generator configuration #122

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

tbinna
Copy link
Member

@tbinna tbinna commented Jun 7, 2024

  • update the app generator to create Forge apps that utilize a native Nx build task to bundle the app and the package executor
  • adds support for esbuild bundler
  • removes target generation in project.json for inferred targets
  • removes package.json from app generator because it is generated by the plugin
  • reduce init generator to only set up the plugin

@tbinna tbinna force-pushed the feature/split-build-target-into-build-and-package branch from f5eb94c to 6362235 Compare June 7, 2024 11:42
@tbinna
Copy link
Member Author

tbinna commented Jun 7, 2024

The generated Forge app Webpack build suffers from an Nx plugin bug that keeps generating a main.js file in addition to the index.js file. Once the Nx bug is resolved, this should be fixed automatically.

@tbinna tbinna force-pushed the feature/split-build-target-into-build-and-package branch 6 times, most recently from 1c1b943 to 382358a Compare June 10, 2024 11:24
@tbinna tbinna force-pushed the feature/split-build-target-into-build-and-package branch from 382358a to 184793b Compare June 17, 2024 08:14
@tbinna tbinna force-pushed the feature/split-build-target-into-build-and-package branch from 184793b to 979ec1a Compare July 2, 2024 03:48
update the app generator to create Forge apps that utilize a native Nx build task to bundle the app and the package executor; adds support for esbuild bundler; removes target generation in project.json for inferred targets; removes package.json from app generator because it is generated by the plugin; reduce init generator to only set up the plugin

Closes #121, #68
@tbinna tbinna force-pushed the feature/split-build-target-into-build-and-package branch from 979ec1a to 9884854 Compare July 2, 2024 03:55
@tbinna tbinna merged commit 1cca34e into beta Jul 2, 2024
2 checks passed
@tbinna tbinna deleted the feature/split-build-target-into-build-and-package branch July 2, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant