Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast: check for duplicate feature when adding type parameter #4612

Merged
merged 1 commit into from
Jan 15, 2025
Merged

ast: check for duplicate feature when adding type parameter #4612

merged 1 commit into from
Jan 15, 2025

Conversation

michaellilltokiwa
Copy link
Member

fixes #4540

@michaellilltokiwa michaellilltokiwa added bug Something isn't working front end related to the front end until .fum file is created: call and type resolution, type checking, etc. labels Jan 14, 2025
@michaellilltokiwa michaellilltokiwa requested a review from a team January 14, 2025 15:41
maxteufel
maxteufel approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@maxteufel maxteufel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to be only broken due to the flaky ctrie test...

@michaellilltokiwa michaellilltokiwa merged commit 2106eaf into tokiwa-software:main Jan 15, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxteufel maxteufel maxteufel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working front end related to the front end until .fum file is created: call and type resolution, type checking, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AoC: While working with memoization, I ran into a crash
2 participants
@michaellilltokiwa @maxteufel