Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't trigger clippy::let_with_type_underscore warning in tracing macro expansion #2515

Closed
wants to merge 0 commits into from
Closed

fix: don't trigger clippy::let_with_type_underscore warning in tracing macro expansion #2515

wants to merge 0 commits into from

Conversation

mrnossiom
Copy link

Motivation

Fixes: #2503

Solution

The first naive fix is to silence the warning, but maybe it is preferred that the underscore does not appear in the expansion.

@mrnossiom mrnossiom requested review from hawkw, davidbarsky and a team as code owners March 18, 2023 13:18
@mrnossiom mrnossiom closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Banyc Banyc Banyc approved these changes

@hawkw hawkw Awaiting requested review from hawkw

@davidbarsky davidbarsky Awaiting requested review from davidbarsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

instrument macro sometimes triggers clippy::let_with_type_underscore
2 participants
@mrnossiom @Banyc