macros: make select budget-aware #7111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maminrayej
added
A-tokio
maminrayej
force-pushed
the
feat/budget-aware-select
branch
from
ec44313 to
762526e
Compare
Darksonn
reviewed
Jan 20, 2025
Comment on lines
+50
to
+59
| #[cfg_attr(docsrs, doc(cfg(feature = "rt")))] | ||
| pub fn poll_budget_available(cx: &mut Context<'_>) -> Poll<()> { | ||
| ready!(crate::trace::trace_leaf(cx)); | ||
| if crate::runtime::coop::has_budget_remaining() { | ||
| Poll::Ready(()) | ||
| } else { | ||
| cx.waker().wake_by_ref(); | ||
| Poll::Pending | ||
| } | ||
| } |
There was a problem hiding this comment.
I think that the poll_proceed / made_progress API we use internally is good. If we're going to expose more of coop, then I think we should expose that API instead of inventing a new one.
But I wouldn't do both "expose coop API" and "make select coop aware" in one PR. I'd like two PRs for the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new function called
poll_budget_availablewhich can be called in order to poll for budget availability. This is then used inselect!, before polling the branches, in order to make select budget-aware.Resolves #7108.