Make action_for_key a weak symbol #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmk could you pull this in? I'm doing some work on some extended functionality and I would rather not modify anything in tmk_core. |
|
👍 to this. Working with Planck/Ergodox/HHKB builds on my end. |
|
+1, would be nice to have. |
dankm
force-pushed
the
tmk_core_action
branch
from
69052ab to
12616e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the compile error in and re-applies
c17b8a5.
Its purpose is to help with some cleanup in the Planck Keyboard's fork. It overrides this function to add some custom code before running a copy-and-pasted version of the default action_for_key.