care partner alerts APNs configuration #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewollesen
force-pushed
the
eric-alerts-config
branch
from
b512892 to
ddfe3fc
Compare
toddkazakov
requested changes
Oct 8, 2024
| configmap: | ||
| enabled: true | ||
| data_: | ||
| pusherAPNSKeyID: "QA3495JW4S" |
There was a problem hiding this comment.
Suggested change
| pusherAPNSKeyID: "QA3495JW4S" | |
| PusherAPNSKeyID: "QA3495JW4S" |
| enabled: true | ||
| data_: | ||
| pusherAPNSKeyID: "QA3495JW4S" | ||
| pusherAPNSTeamID: "75U4X84TEG" |
There was a problem hiding this comment.
Suggested change
| pusherAPNSTeamID: "75U4X84TEG" | |
| PusherAPNSTeamID: "75U4X84TEG" |
| data_: | ||
| pusherAPNSKeyID: "QA3495JW4S" | ||
| pusherAPNSTeamID: "75U4X84TEG" | ||
| pusherAPNSBundleID: "org.tidepool.carepartner" |
There was a problem hiding this comment.
Suggested change
| pusherAPNSBundleID: "org.tidepool.carepartner" | |
| PusherAPNSBundleID: "org.tidepool.carepartner" |
| valueFrom: | ||
| configMapKeyRef: | ||
| name: data | ||
| key: pusherAPNSBundleID |
There was a problem hiding this comment.
Suggested change
| key: pusherAPNSBundleID | |
| key: PusherAPNSBundleID |
| valueFrom: | ||
| configMapKeyRef: | ||
| name: data | ||
| key: pusherAPNSTeamID |
There was a problem hiding this comment.
Suggested change
| key: pusherAPNSTeamID | |
| key: PusherAPNSTeamID |
| valueFrom: | ||
| secretKeyRef: | ||
| name: data | ||
| key: pusherAPNSSigningKey |
There was a problem hiding this comment.
Suggested change
| key: pusherAPNSSigningKey | |
| key: PusherAPNSSigningKey |
| # If you're running locally via the development cluster, you'll need to | ||
| # base64-encode the contents of that file, and add the resulting data to the | ||
| # secret. You'll also need to enable the secret in local/Tiltconfig.yaml. | ||
| pusherAPNSSigningKey: {{ .Values.secret.data_.pusherAPNSSigningKey | default "" | quote }} |
There was a problem hiding this comment.
Suggested change
| pusherAPNSSigningKey: {{ .Values.secret.data_.pusherAPNSSigningKey | default "" | quote }} | |
| PusherAPNSSigningKey: {{ .Values.secret.data_.Pusher.APNS.SigningKey | default "" | quote }} |
| {{ include "charts.labels.standard" . }} | ||
| {{ with .Values.configmap.data_ }} | ||
| data: | ||
| pusherAPNSKeyID: {{ .pusherAPNSKeyID | default "" }} |
There was a problem hiding this comment.
Suggested change
| pusherAPNSKeyID: {{ .pusherAPNSKeyID | default "" }} | |
| pusherAPNSKeyID: {{ .PusherAPNSKeyID | default "" }} |
| {{ with .Values.configmap.data_ }} | ||
| data: | ||
| pusherAPNSKeyID: {{ .pusherAPNSKeyID | default "" }} | ||
| pusherAPNSTeamID: {{ .pusherAPNSTeamID | default "" }} |
There was a problem hiding this comment.
Suggested change
| pusherAPNSTeamID: {{ .pusherAPNSTeamID | default "" }} | |
| PusherAPNSTeamID: {{ .pusherAPNSTeamID | default "" }} |
| data: | ||
| pusherAPNSKeyID: {{ .pusherAPNSKeyID | default "" }} | ||
| pusherAPNSTeamID: {{ .pusherAPNSTeamID | default "" }} | ||
| pusherAPNSBundleID: {{ .pusherAPNSBundleID | default "" }} |
There was a problem hiding this comment.
Suggested change
| pusherAPNSBundleID: {{ .pusherAPNSBundleID | default "" }} | |
| PusherAPNSBundleID: {{ .pusherAPNSBundleID | default "" }} |
It includes kafka channels that are watched for messages to trigger evaluation of alerts criteria used to then send push notifications to mobile devices. BACK-2554
The options key isn't permitted to be a null object, so only include it at all if shadowing is enabled.
ewollesen
force-pushed
the
eric-alerts-config
branch
from
ddfe3fc to
f34a394
Compare
toddkazakov
previously approved these changes
Nov 22, 2024
toddkazakov
previously approved these changes
Nov 23, 2024
…ntiate b/t services w/o having to modify code of existing services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.