-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new option to run just new jobs or jobs without history #831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
ae415cc
to
c3e02a9
Compare
I added the redis version of has_history_data() to it but it just wraps around get_history_data() since redis is already fast. For this a new cache.db was used and a redis server that runs on a debian stable vm.
The time is just the loop for all jobs over has/get_history_data() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Please also add a changelog entry to the PR.
Just a entry in the CHANGELOG.md? If yes its done. And everyone i hope you all had a happy new year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the updates!
@nille02 Can you fix up the last remaining code style issues?
After that, this is ready to merge :) |
Should be fixed now |
There's still 3 more:
(you can run this locally to verify it's fixed, no need to wait for CI -- use |
New command-line option `--prepare-jobs` to initialize new jobs or jobs without history Fix some typos Fix Again
Now it should be done. I did try pytest but i got some different error and i guess its due to windows. So had to skip the documentation test but pep8 was happy now. |
Thanks for working on this and seeing it through! Merged :) |
I have the issue that i have some url.yaml files with hundreds to thousands of jobs. A full run can take hours and i do that in general just once a month or even less.
Before that option i checked for the new ids and run them manual. but it was quite the chore and i looked how i can avoid that.
My only issue is that get_history_data() is quite slow but i guess sqllite is the reason?