Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bundler to 2.1.4 #1665

Closed
wants to merge 2 commits into from
Closed

Conversation

sedubois
Copy link
Contributor

@sedubois sedubois commented Jun 4, 2020

No description provided.

@nickcharlton
Copy link
Member

Thanks for thinking of this! There's an existing PR that's looking at this: #1548, which ended up coming up with more questions about Rails <5 support and a requirement to change something in Appraisal too (which I'm going to be looking at tomorrow (2020-06-05).

I'm going to close this so that we can keep to those original PRs.

@nickcharlton nickcharlton added dependencies changes or issues relating to a dependency maintenance to keep up with changes around us labels Jun 4, 2020
@sedubois
Copy link
Contributor Author

sedubois commented Jun 4, 2020

NB: the linked PR actually does not seem to be updating bundler, it's still at version 1.17.3:
/~https://github.com/thoughtbot/administrate/pull/1548/files#diff-e79a60dc6b85309ae70a6ea8261eaf95L287

@nickcharlton
Copy link
Member

Ah yeah, you're right. I might've been thinking about this PR for Appraisal, but also I note you did this previously!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies changes or issues relating to a dependency maintenance to keep up with changes around us
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants