Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we drop Rails <5 support? #1588

Closed
nickcharlton opened this issue Mar 26, 2020 · 6 comments
Closed

Should we drop Rails <5 support? #1588

nickcharlton opened this issue Mar 26, 2020 · 6 comments
Labels
dependencies changes or issues relating to a dependency maintenance to keep up with changes around us

Comments

@nickcharlton
Copy link
Member

This would mean removing the Rails 4.2 Appraisal. But are there other things we could also remove?

Are any of you still/stuck on Rails lower than 5?

This originally came up in #1581, as it's a feature that's not possible to do yet.

@nickcharlton nickcharlton added dependencies changes or issues relating to a dependency maintenance to keep up with changes around us labels Mar 26, 2020
@nickcharlton
Copy link
Member Author

Another reason: Bundler 2 and Rails 4.2 are causing problems with Appriasal: thoughtbot/appraisal#168, which in-turn is related to our own #1548 and #1549.

@deivid-rodriguez
Copy link
Contributor

deivid-rodriguez commented Mar 26, 2020

Note that the underlying issue with ruby 2.7 is that Rails 4.2 is not compatible with Ruby 2.7 because it uses a bigdecimal 1.x interface, but bigdecimal 2.0.0 is provided by default on ruby 2.7.

My recommendation would be to:

  • Upgrade to bundler 2.1, which fixes the other issue you're having when testing against ruby 2.7.
  • Remove the ruby 2.7 + Rails 4.2 combination from the CI matrix.

@deivid-rodriguez
Copy link
Contributor

deivid-rodriguez commented Mar 26, 2020

I mean, I'd probably drop support for old Rails versions too, but that sounds like a separate discussion (the one this issue is meant for, sorry for the noise 😅) and not a requirement to start testing against ruby 2.7.

@composerinteralia
Copy link
Contributor

factory_bot and factory_bot_rails are dropping support for Rails 4.2 in the next major release (they might still work with 4.2, but I will not be running the tests with that version anymore). I was having similar fights with Rails 4.2 locking to bundler < 2.

Rails 4.2 is no longer being maintained, so if there is additional maintenance burden to support it here I think we should drop support.

@nickcharlton
Copy link
Member Author

Yeah — we're going to do the same (I realise I didn't actually write this on this issue). Administrate 1.0.0 (which will be it) won't support Rails 4.2.

@nickcharlton
Copy link
Member Author

I've opened #1740, which removes support for everything below Rails 5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies changes or issues relating to a dependency maintenance to keep up with changes around us
Projects
None yet
Development

No branches or pull requests

3 participants