-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we drop Rails <5 support? #1588
Comments
Another reason: Bundler 2 and Rails 4.2 are causing problems with Appriasal: thoughtbot/appraisal#168, which in-turn is related to our own #1548 and #1549. |
Note that the underlying issue with ruby 2.7 is that Rails 4.2 is not compatible with Ruby 2.7 because it uses a My recommendation would be to:
|
I mean, I'd probably drop support for old Rails versions too, but that sounds like a separate discussion (the one this issue is meant for, sorry for the noise 😅) and not a requirement to start testing against ruby 2.7. |
factory_bot and factory_bot_rails are dropping support for Rails 4.2 in the next major release (they might still work with 4.2, but I will not be running the tests with that version anymore). I was having similar fights with Rails 4.2 locking to bundler < 2. Rails 4.2 is no longer being maintained, so if there is additional maintenance burden to support it here I think we should drop support. |
Yeah — we're going to do the same (I realise I didn't actually write this on this issue). Administrate 1.0.0 (which will be it) won't support Rails 4.2. |
I've opened #1740, which removes support for everything below Rails 5.0. |
This would mean removing the Rails 4.2 Appraisal. But are there other things we could also remove?
Are any of you still/stuck on Rails lower than 5?
This originally came up in #1581, as it's a feature that's not possible to do yet.
The text was updated successfully, but these errors were encountered: