Use left joins instead of inner join when searching

thoughtbot · Sep 3, 2020 · 8289b1c · 8289b1c
1 parent 1234bc7
commit 8289b1c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/administrate/search.rb b/lib/administrate/search.rb
@@ -109,7 +109,7 @@ def search_attributes
 
     def search_results(resources)
       resources.
-        joins(tables_to_join).
+        left_joins(tables_to_join).
         where(query_template, *query_values)
     end
 

diff --git a/spec/lib/administrate/search_spec.rb b/spec/lib/administrate/search_spec.rb
@@ -152,14 +152,14 @@ class User < ApplicationRecord; end
       it "joins with the correct association table to query" do
         allow(scoped_object).to receive(:where)
 
-        expect(scoped_object).to receive(:joins).with(%i(role author address)).
+        expect(scoped_object).to receive(:left_joins).with(%i(role author address)).
           and_return(scoped_object)
 
         search.run
       end
 
       it "builds the 'where' clause using the joined tables" do
-        allow(scoped_object).to receive(:joins).with(%i(role author address)).
+        allow(scoped_object).to receive(:left_joins).with(%i(role author address)).
           and_return(scoped_object)
 
         expect(scoped_object).to receive(:where).with(*expected_query)