Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Simplify recursive init outputs #2204

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Jan 12, 2025

Follow up of #2150

The strings.Builder-based approach is complicated to implement, so we'll change it to a simpler output.

without --recursive

Installed

No changes

Already installed

Before

$ tflint --init
Plugin "aws" is already installed
Plugin "google" is already installed

After

$ tflint --init
All plugins are already installed

with --recursive

Installed

Before

Installing plugins on each working directory...

====================================================
working directory: .

No plugins to install
====================================================
working directory: subdir

Installing "aws" plugin...
Installed "aws" (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.34.0)
====================================================
working directory: subdir2

Installing "google" plugin...
Installed "google" (source: github.com/terraform-linters/tflint-ruleset-google, version: 0.30.0)

After

$ tflint --recursive --init
Installing "aws" plugin in subdir...
Installed "aws" (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.34.0)
Installing "google" plugin in subdir2...
Installed "google" (source: github.com/terraform-linters/tflint-ruleset-google, version: 0.30.0)

Already installed

Before

Installing plugins on each working directory...

====================================================
working directory: .

No plugins to install
====================================================
working directory: subdir

Plugin "aws" is already installed
====================================================
working directory: subdir2

Plugin "google" is already installed

After

$ tflint --recursive --init
All plugins are already installed

Follow up of #2150

The `strings.Builder`-based approach is complicated to implement,
so we'll change it to a simpler output.
@wata727 wata727 merged commit ced1af6 into master Jan 12, 2025
14 checks passed
@wata727 wata727 deleted the tweak_recursive_init_output branch January 12, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant