Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for response_parameters in integrations #58

Conversation

mattoddie
Copy link
Contributor

Description

Add support for "response_parameters" to an integration to allow modification of response headers.

Motivation and Context

It is not possible to set the "response_parameters" block on an integration using this module, which can be useful for setting security headers that get added to all API responses.

Breaking Changes

There are no breaking changes

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update versions.tf in the root and in example with the minimum version of AWS provider where this feature was introduced - 3.24.0.

/~https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#3240-january-14-2021

@mattoddie
Copy link
Contributor Author

Please update versions.tf in the root and in example with the minimum version of AWS provider where this feature was introduced - 3.24.0.

/~https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#3240-january-14-2021

@antonbabenko thanks for spotting that! Updated.

@antonbabenko antonbabenko merged commit 5b54d05 into terraform-aws-modules:master Nov 1, 2021
@antonbabenko
Copy link
Member

Thanks, @mattoddie !

v1.5.0 has been just released.

@mattoddie mattoddie deleted the feature/integration-response-parameters branch November 2, 2021 08:34
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants