Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libllvm: replace arm-linux-androideabi-clang symlink with wrapper #7856

Merged
merged 1 commit into from
Oct 26, 2021
Merged

libllvm: replace arm-linux-androideabi-clang symlink with wrapper #7856

merged 1 commit into from
Oct 26, 2021

Conversation

Grimler91
Copy link
Member

This is the same wrapper as what the ndk uses for selecting api level.

This fixes #7232 and #7839.

@Grimler91
libllvm: replace arm-linux-androideabi-clang symlink with wrapper
04b73f5 
This is the same wrapper as what the ndk uses for selecting api level.

This fixes #7232 and
#7839.
@Grimler91 Grimler91 requested a review from finagolfin as a code owner October 26, 2021 06:50
finagolfin
finagolfin approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@finagolfin finagolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use these wrappers and they predate my maintaining this package, but seems fine to me.

No reason to run this small change through the PR CI again if you tested it locally.

@Grimler91 Grimler91 merged commit f32b2c0 into master Oct 26, 2021
@Grimler91 Grimler91 deleted the llvm-arm-triple branch October 26, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finagolfin finagolfin finagolfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Grimler91 @finagolfin