[e2e] Run regression tests in PR presubmits #6896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #6895 |
Regression tests don't take too long to run, and they can catch more errors. This PR enables them for PR presubmits.
mattsoulanille
force-pushed
the
regression_e2e_presubmits
branch
from
57fdb95 to
4d25e63
Compare
pyu10055
requested changes
Oct 4, 2022
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @ahmedsabie and @mattsoulanille)
e2e/scripts/test-ci.sh line 53 at r1 (raw file):
node ../scripts/run_flaky.js "yarn run-browserstack --browsers=win_10_chrome --tags '$TAGS'" node ../scripts/run_flaky.js "yarn run-browserstack --browsers=bs_safari_mac --tags '$TAGS' --testEnv webgl --flags '{"\""WEBGL_VERSION"\"": 1, "\""WEBGL_CPU_FORWARD"\"": false, "\""WEBGL_SIZE_UPLOAD_UNIFORM"\"": 0}'"
remove this test given WebGL1 is not by default after safari 15
pyu10055
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @ahmedsabie and @mattsoulanille)
ahmedsabie
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression tests don't take too long to run, and they can catch more errors. This PR enables them for PR presubmits.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is