rust: add rustfmt.toml to set edition = "2018"
#4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
they previously "fixed the glitch" by just defaulting
rust-modeto 2018 edition
Scare quotes indeed, since that’s a breaking change; it’s very much
intentional that editions default to 2015 in Rustc/Cargo/etc. In any
case, this change is fine with me, and happy to accommodate.
| @@ -17,6 +17,7 @@ | |||
| name = "rustboard" | |||
| version = "0.4.0-alpha.0" | |||
| authors = ["The TensorFlow Authors <tensorboard-gardener@google.com>"] | |||
| # Keep in sync with `edition` in rustfmt.toml. | |||
There was a problem hiding this comment.
For what it’s worth, also Bazel targets. (No action required.)
There was a problem hiding this comment.
Ack, thanks for pointing that out; will leave as-is since I think rustfmt.toml is the place that's more likely to be forgotten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes my emacs formatting work again now that we use
async: rust-lang/rustfmt#4454The ideal solution would probably be if
rust-modewere to inspectCargo.tomland pass the edition from there intorustfmt, but this is a quicker fix than trying to send them that patch. Also they previously "fixed the glitch" by just defaultingrust-modeto 2018 edition so I'm not sure they would even take the patch; I still ran into this issue since internal to Googlerust-modeis outdated. Besides, it seems technically more correct to have therustfmtedition derived from the repo rather than set to a global default that happens to work for our project.