Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eigen header locations for TF 2.16 #2863

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

trevor-m
Copy link
Contributor

@trevor-m trevor-m commented Mar 25, 2024

Description

Eigen header path was changed in TF 2.16. This PR fixes the build error.

Fixes #2860

Type of change

  • Bug fix

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@trevor-m trevor-m force-pushed the tmorris-eigenheaders branch from 1238d33 to f753042 Compare March 25, 2024 21:18
@plopresti
Copy link

I can confirm that this fixes #2860 (thank you).

Any chance of seeing this merged?

@bhack bhack requested review from bhack and seanpmorgan April 15, 2024 22:04
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@seanpmorgan seanpmorgan merged commit d208d75 into tensorflow:master Apr 15, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure against TF r2.16: third_party/eigen3/unsupported/Eigen/CXX11/Tensor: No such file or directory
4 participants