Expose workflow client from Activity #1783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // service from an activity. | ||
| func GetClient(ctx context.Context) Client { | ||
| activityEnv := getActivityEnv(ctx) | ||
| return activityEnv.serviceInvoker.GetClient(ClientOptions{Namespace: activityEnv.workflowNamespace}) |
There was a problem hiding this comment.
hm, but you are not using the client , or client options the worker was started with. So if the worker client was configured with a data converter or interceptor I don't think this client will have it.
There was a problem hiding this comment.
I think you might need to just wire the client from worker constructor down to here.
cretz
reviewed
Jan 17, 2025
| @@ -26,7 +26,7 @@ package activity | |||
|
|
|||
| import ( | |||
| "context" | |||
|
|
|||
| "go.temporal.io/sdk/client" | |||
There was a problem hiding this comment.
I am slightly concerned about this package dependency. We now will never be able to have any package that client depends on depend on the activity package. Maybe that's ok? I wonder if it'd be ok to just do just have GetClient return internal.Client instead. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a new
GetClientfunction in theactivitypackageWhy?
Allow users to access Temporal client from within an activity
Checklist
Closes Provide client from activity context #1761
How was this tested:
Add unit and integration test
Any docs updates needed?