Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigInt to stage 4 #217

Merged
merged 1 commit into from
Sep 27, 2019
Merged

BigInt to stage 4 #217

merged 1 commit into from
Sep 27, 2019

Conversation

chicoxyzzy
Copy link
Member

No description provided.

@cjihrig cjihrig mentioned this pull request Jun 4, 2019
Merged
@mysticatea mysticatea mentioned this pull request Jun 4, 2019
Closed
6 tasks
@g-plane g-plane mentioned this pull request Jun 4, 2019
Closed
@mysticatea mysticatea mentioned this pull request Jun 4, 2019
Merged
@andykais andykais mentioned this pull request Jun 4, 2019
Closed
ljharb
ljharb requested changes Jun 4, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is premature, for multiple reasons: the notes aren't released, the meeting hasn't concluded, and neither of these proposals is technically eligible for stage 4 at this time, so that consensus is thus conditional on meeting that criteria.

@chicoxyzzy
Copy link
Member Author

chicoxyzzy commented Jun 4, 2019 •
edited
Loading

Oh sorry, I didn't know about that. Are these criteria should only be met by features that looking for stage 4?

@ljharb
Copy link
Member

ljharb commented Jun 5, 2019

Yes - specifically, to be eligible for stage 4, editors have to have signed off on a PR to the spec repo.

@chicoxyzzy
Copy link
Member Author

Indeed. Sorry for my rush.

@ljharb ljharb force-pushed the june2019_update branch from a67b0e0 to 3f77b9d Compare June 6, 2019 13:43
@charmander charmander mentioned this pull request Jun 9, 2019
Closed
@chicoxyzzy chicoxyzzy changed the title June 2019 meeting update BigInt to stage 4 Jun 18, 2019
@ljharb ljharb force-pushed the june2019_update branch from 3f77b9d to cecb2e3 Compare July 7, 2019 05:07
@littledan
Copy link
Member

I think it's time to land this PR.

@ljharb
Copy link
Member

ljharb commented Sep 27, 2019

tc39/ecma262#1515 has just received final editor approval today; as such, BigInt now meets all stage 4 criteria. Rebasing and merging.

@ljharb ljharb merged commit 9f0a8f0 into tc39:master Sep 27, 2019
@chicoxyzzy chicoxyzzy deleted the june2019_update branch September 27, 2019 10:38
@exoego exoego mentioned this pull request Sep 28, 2019
Merged
3 tasks
@viluon viluon mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chicoxyzzy @ljharb @littledan