Skip to content

Commit

Permalink
deps: fix V8 build for GCC 6
Browse files Browse the repository at this point in the history
V8 erroneously does null pointer checks on `this`.
It can lead to a SIGSEGV crash if node is compiled with GCC 6.
Enable -fno-delete-null-pointer-checks to circumvent this issue.

Ref: nodejs#6272
  • Loading branch information
targos committed Apr 27, 2016
1 parent 23818c6 commit e13fbff
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions deps/v8/build/toolchain.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -1070,6 +1070,7 @@
'cflags': [ '-fno-strict-aliasing' ],
}],
], # conditions
'cflags': [ '-fno-delete-null-pointer-checks' ]
}],
['OS=="solaris"', {
'defines': [ '__C99FEATURES__=1' ], # isinf() etc.
Expand Down

0 comments on commit e13fbff

Please sign in to comment.