-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add key expiration to tailscale_tailnet_key #175
Conversation
@DentonGentry Haven't looked too closely at your CI setup, but does this depend on the published client pkg? |
I created a v1.7.0 release in tailscale-client-go. You should be able to update to that version of the module and try again:
|
dependabot sent a PR to update this repo to 1.7. You'll need to rebase your PR to pull that change in:
|
Didn't realize the docs were generated - should I remove my manual edits? |
Yes, please remove the docs changes. If we want to update the docstring we'd go back to the source document. |
You'll need to install the tfplugindocs tool and then run |
@@ -2,4 +2,5 @@ resource "tailscale_tailnet_key" "sample_key" { | |||
reusable = true | |||
ephemeral = false | |||
preauthorized = true | |||
expiry = 3600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run terraform fmt
on this example just so the indentation is correct.
Great! This looks good, and the CI is happy. |
@DentonGentry @davidsbond thank you both for the guidance, and for a great service! :) |
What this PR does / why we need it:
Adds key expiration option to the
tailscale_tailnet_key
resourceWhich issue this PR fixes
N/A
Special notes for your reviewer:
See tailscale/tailscale-client-go#34 for associated client change