Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groundwork to support creating a capital gains report #2

Merged
merged 9 commits into from
May 10, 2024

Conversation

tacgomes
Copy link
Owner

No description provided.

tacgomes added 9 commits May 10, 2024 20:21
Add the amount filter to the list of filters to enable viewing only
deposits or only withdraws.
Create decimals always from a string argument mainly for accuracy but
also for consistency reasons.
Process the Freetrade transactions in reverse order so that the oldest
order gets the smallest ID number.
For tax calculations we will be pooling orders together and splitting
orders in two. In these situations, there's nothing appropriate to set
on the `order_id` field, so this field is made optional.
Add a `date` property to the base `Transaction` class for convenience
reasons.
Add methods to merge and split orders. They will be used when
calculating capital gains/losses in a following commit.
Make `fees` an optional field to simplify writing unit tests.
@tacgomes tacgomes force-pushed the tiago.gomes/tax-calculator-1 branch from 4c90fba to cbd7cac Compare May 10, 2024 19:32
@tacgomes tacgomes merged commit 47c2a07 into main May 10, 2024
6 checks passed
@tacgomes tacgomes deleted the tiago.gomes/tax-calculator-1 branch May 12, 2024 11:43
@tacgomes tacgomes changed the title Groundwork for supporting a capital gains report Groundwork to support creating a capital gains report Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant