Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to react-native 0.74 #2050

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Jul 9, 2024

Description

  • Upgrade react-native to 0.74.3 according to https://react-native-community.github.io/upgrade-helper/
  • Update yarn version which is default for new RN projects
  • Replace lottie-react-native with react-native-skottie (because of build error on Android)
  • Remove TextEncoder polyfill (now supported) and only leave TextDecoder
  • Replace stream-browserify with readable-stream which is maintained
  • Update some dependencies
  • Fix new lint errors

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

Check for regression

@pwltr pwltr force-pushed the chore/upgrade-react-native branch from 8b60d78 to f83f6ce Compare July 9, 2024 12:29
@pwltr pwltr marked this pull request as ready for review July 9, 2024 12:29
Copy link

socket-security bot commented Jul 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eslint-community/regexpp@4.10.1 None 0 432 kB eslint-community-bot
npm/@gorhom/bottom-sheet@4.6.3 None +2 1.82 MB gorhom
npm/@react-native-async-storage/async-storage@1.22.3 None 0 430 kB krizzu
npm/@react-native-clipboard/clipboard@1.14.1 Transitive: environment, eval, filesystem, network, shell, unsafe +66 88.9 MB naturalclar
npm/@react-native/babel-preset@0.74.85 environment Transitive: unsafe +18 2.27 MB react-native-bot
npm/@react-native/eslint-config@0.74.85 Transitive: environment, filesystem, unsafe +48 11.3 MB react-native-bot
npm/@react-native/metro-config@0.74.85 Transitive: environment, filesystem +2 37.4 kB react-native-bot
npm/@react-native/typescript-config@0.74.85 None 0 2 kB react-native-bot
npm/@types/react@18.3.3 None +2 1.66 MB types
npm/agent-base@7.1.1 network 0 31.2 kB tootallnate
npm/async@3.2.4 None 0 821 kB hargasinski
npm/bitkit@0.0.0-use.local None 0 0 B
npm/es-define-property@1.0.0 Transitive: eval +2 65.7 kB ljharb

🚮 Removed packages: npm/@eslint-community/regexpp@4.10.0, npm/@gorhom/bottom-sheet@4.6.1, npm/@react-native-async-storage/async-storage@1.21.0, npm/@react-native-clipboard/clipboard@1.12.1, npm/@react-native/eslint-config@0.73.2, npm/@react-native/metro-config@0.73.5, npm/@react-native/typescript-config@0.73.1, npm/@types/react@18.2.78, npm/agent-base@6.0.2, npm/async@3.2.5, npm/bn.js@5.2.1, npm/browserify-aes@1.2.0, npm/browserify-rsa@4.1.0, npm/evp_bytestokey@1.0.3, npm/fast-deep-equal@3.1.3, npm/fast-json-stable-stringify@2.1.0, npm/fast-xml-parser@4.3.4, npm/fastestsmallesttextencoderdecoder-encodeinto@1.0.22, npm/fetch-blob@3.2.0, npm/flow-parser@0.206.0, npm/follow-redirects@1.15.2, npm/function.prototype.name@1.1.6, npm/fuzzysort@1.9.0, npm/get-caller-file@2.0.5, npm/get-intrinsic@1.2.2

View full report↗︎

@pwltr pwltr force-pushed the chore/upgrade-react-native branch 2 times, most recently from 1576003 to c3638aa Compare July 9, 2024 12:40
@pwltr
Copy link
Collaborator Author

pwltr commented Jul 9, 2024

Currently blocked by react-native-clipboard/clipboard#246

@pwltr pwltr force-pushed the chore/upgrade-react-native branch from c3638aa to ab14c72 Compare July 9, 2024 13:45
@pwltr pwltr requested a review from limpbrains as a code owner July 9, 2024 13:45
@pwltr pwltr force-pushed the chore/upgrade-react-native branch 4 times, most recently from a5b1e2b to 56e7929 Compare July 10, 2024 11:46
@pwltr pwltr self-assigned this Jul 10, 2024
@ovitrif
Copy link
Contributor

ovitrif commented Jul 11, 2024

FYI would love to see this merged and shipped in the next version :), a user is already waiting for it in hope it fixes their frozen UI

@pwltr
Copy link
Collaborator Author

pwltr commented Jul 11, 2024

FYI would love to see this merged and shipped in the next version :), a user is already waiting for it in hope it fixes their frozen UI

I don't expect this to really solve any major issues, just some minor performance and bundle size gains. But will be a stepping stone for more performance improvements.

@pwltr pwltr force-pushed the chore/upgrade-react-native branch from 56e7929 to 7903537 Compare July 11, 2024 10:22
Copy link

socket-security bot commented Jul 11, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@pwltr pwltr force-pushed the chore/upgrade-react-native branch from 7903537 to 365825c Compare July 11, 2024 11:50
@pwltr pwltr force-pushed the chore/upgrade-react-native branch from 365825c to cbb37c1 Compare July 11, 2024 15:18
@pwltr pwltr requested a review from limpbrains July 11, 2024 16:04
@pwltr
Copy link
Collaborator Author

pwltr commented Jul 11, 2024

I think this is good to go now

@pwltr pwltr merged commit 94bdef3 into master Jul 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants