Skip to content

Commit

Permalink
bug #523 Fix accessing PantherTestCaseTrait::$webServerDir before i…
Browse files Browse the repository at this point in the history
…nitialization (kbond)

This PR was merged into the 2.0.x-dev branch.

Discussion
----------

Fix accessing `PantherTestCaseTrait::$webServerDir` before initialization

`PantherTestCaseTrait::getWebServerDir()` can access `PantherTestCaseTrait::$webServerDir` before it's initialized. I believe this was just missed in #517.

Commits
-------

39efc06 fix "webServerDir must not be accessed before initialization"
  • Loading branch information
chalasr committed Dec 2, 2021
2 parents b3bc87d + 39efc06 commit dc57282
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
CHANGELOG
=========

2.0.1
-----

* Fix accessing `PantherTestCaseTrait::$webServerDir` before initialization

2.0.0
-----

Expand Down
2 changes: 1 addition & 1 deletion src/PantherTestCaseTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ trait PantherTestCaseTrait
{
public static bool $stopServerOnTeardown = true;

protected static ?string $webServerDir;
protected static ?string $webServerDir = null;

protected static ?WebServerManager $webServerManager = null;

Expand Down

0 comments on commit dc57282

Please sign in to comment.