New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* core/core-themes-support.el: Remove unnecessary "eval" #16796

Merged

smile13241324 merged 1 commit into syl20bnr:develop from sunlin7:theme-remove-eval

Jan 19, 2025

Contributor

sunlin7 commented Jan 14, 2025 •

edited

Loading

As discussed in the in the #16783 (comment),
The eval is unnecessary, just remove it.

I found the eval statement in spacemacs//load-theme-internal was first introduced in this commit:
c913ec8
The eval is necessary?

I think it's not necessary now that we're using lexical-binding in that file and also for the macro definition.


          * core/core-themes-support.el: Remove unnecessary "eval"

5ee3ce1

sunlin7 force-pushed the theme-remove-eval branch from acbf917 to 5ee3ce1 Compare

January 14, 2025 20:51

smile13241324 approved these changes

View reviewed changes

smile13241324 merged commit 360886c into syl20bnr:develop

8 of 9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet