Propagate sanitizer arguments to the clang-linker-driver invocations for dynamic libraries #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for dynamic libraries Unless we are building a static library, we need to propagate `-fsanitizer=` flag to the clang linker driver, otherwise sanitizers libraries will not be found at link-time. Resolves rdar://107733898
artemcm
force-pushed
the
SanitizersForAll_dylibs
branch
from
ceef248 to
e769d62
Compare
artemcm
commented
Apr 6, 2023
| @@ -199,7 +199,7 @@ extension DarwinToolchain { | |||
| // Linking sanitizers will add rpaths, which might negatively interact when | |||
| // other rpaths are involved, so we should make sure we add the rpaths after | |||
| // all user-specified rpaths. | |||
| if linkerOutputType == .executable && !sanitizers.isEmpty { | |||
| if linkerOutputType != .staticLibrary && !sanitizers.isEmpty { | |||
There was a problem hiding this comment.
@keith do you, by any chance, remember why we had this restriction for .executable?
!= .staticLibrary seems like the right thing to do here.
There was a problem hiding this comment.
hrm im not sure, maybe I got it from this /~https://github.com/apple/swift-driver/blob/7a96ffdd68dda2049cc2da005493b872ea43e3bc/Sources/SwiftDriver/Jobs/GenericUnixToolchain%2BLinkerSupport.swift#L272, I think you're right though
There was a problem hiding this comment.
besides previously there was a check for excluding the fuzzer sanitizer for executables, so you might want that back a557d59#diff-d44ec7a906797a39be2e42ecb334167ae217537ad09a726d1f905c4ba9130200L365
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless we are building a static library, we need to propagate
-fsanitizer=flag to the clang linker driver, otherwise sanitizers libraries will not be found at link-time.Resolves rdar://107733898