Windows: tweak LTSC2022 nightly image creation

[compnerd]

• Use HTTPS for the latest download info.
• Immediately convert from JSON to help make failures more understandable.
• Perform the JSON conversion once to avoid repeated parsing.

[compnerd]

@swift-ci please test

[weliveindetail]

@compnerd Looks like this change broke the xInfrastructure docker bot:

 ConvertFrom-Json : Cannot bind argument to parameter 'InputObject' because it is null.
At line:1 char:221
  + ... org/development/windows10/$($($env:Release | ConvertFrom-JSON).dir)/$ ...
  +                                                  ~~~~~~~~~~~~~~~~
      + CategoryInfo          : InvalidData: (:) [ConvertFrom-Json], ParameterBindingValidationException
      + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.ConvertFromJsonCommand

Attaching the full log here: xInfrastructure-docker-41.log

[compnerd]

@weliveindetail that seems odd - this change removes the referenced code 🤔

[weliveindetail]

Oh right! Interesting, the checkout was fine and the subsequent commit didn't touch this code. And still, the build was running the old code?

It turns out that CI is running a different Dockerfile, which wasn't updated: /~https://github.com/compnerd/swift-docker/blob/ac4d1fe17ceedb2194ebcd5ac6beef5cbcda8245/nightly-main/windows/1809/Dockerfile#L132

But why does the old code fail now? I compared to the previous (successful) build. The same RUN line worked well there. There was no other change in the meantime. If the URL is not reachable, we should get a 404 as HTML code, and ConvertFrom-JSON would complain with Invalid JSON primitive.

Not sure what the issue is. Maybe an internal error in curl.exe? I can reproduce the error output locally like this, but we should see error output from curl.exe as well and we don't have that in the logs:

PS S:\> $env:Release = curl.exe -sL ${env:INVALID}
curl: (2) no URL specified
curl: try 'curl --help' for more information

PS S:\> $env:Release | ConvertFrom-JSON
ConvertFrom-Json : Cannot bind argument to parameter 'InputObject' because it is null.
At line:1 char:16
+ $env:Release | ConvertFrom-JSON
+                ~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [ConvertFrom-Json], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.ConvertFromJsonCommand      

Furthermore, the PR-test for this patch failed, but it seems unrelated: https://ci.swift.org/job/pr-swift-docker/156/

[weliveindetail]

The next build failed with the same error: xInfrastructure-docker-42.log Only difference is the checkout from /~https://github.com/apple/swift-continuous-integration-library, that I have no access to:

--- xInfrastructure-docker-41.log
+++ xInfrastructure-docker-42.log
@@ -14,4 +14,4 @@
  > git config core.sparsecheckout # timeout=10
- > git checkout -f a9bd1bcd3594200f230a5aa70dcb8d423ad7c4ae # timeout=10
-Commit message: "Update macOSNewXcodeJob.groovy"
+ > git checkout -f ff79c48990546dbbfdae5c96eecb60f3ed8cf2d4 # timeout=10
+Commit message: "Add support for build command"
 [Pipeline] Start of Pipeline

Assuming for now that the issue originates from there.