Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate initial commit message for Guacamole recipe #1075

Merged

Conversation

mahermanns
Copy link
Contributor

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Fixes #1073

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Instead of using the term template, the episode explicitly states in the initial commit message that it is the initial structure for our first recipe, being a Guacamole recipe.

If any relevant discussions have taken place elsewhere, please provide links to these.

This topic came up in my teaching demo today, where @dpshelio suggested I propose a change, following what I did (in initially creating a file template.md). Contemplating a bit, this adds more action items to the episode, so I would now propose to rather fix the initial commit message instead, keeping the overall number of action items in the episode the same.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

@martinosorb
Copy link
Contributor

I don't see why not.
Thank you.

@martinosorb martinosorb merged commit 1f87e16 into swcarpentry:main Feb 22, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
Auto-generated via `{sandpaper}`
Source  : 1f87e16
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2025-02-22 17:43:57 +0000
Message : Merge pull request #1075 from mahermanns/disambiguate-initial-commit

Disambiguate initial commit message for Guacamole recipe
github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
Auto-generated via `{sandpaper}`
Source  : c3e67eb
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-02-25 11:30:04 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 1f87e16
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2025-02-22 17:43:57 +0000
Message : Merge pull request #1075 from mahermanns/disambiguate-initial-commit

Disambiguate initial commit message for Guacamole recipe
github-actions bot pushed a commit that referenced this pull request Feb 27, 2025
Auto-generated via `{sandpaper}`
Source  : c3e67eb
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-02-25 11:30:04 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 1f87e16
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2025-02-22 17:43:57 +0000
Message : Merge pull request #1075 from mahermanns/disambiguate-initial-commit

Disambiguate initial commit message for Guacamole recipe
@dpshelio
Copy link
Contributor

Beautiful!! Thanks @mahermanns!!! 🚀

github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
Auto-generated via `{sandpaper}`
Source  : c3e67eb
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-02-25 11:30:04 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 1f87e16
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2025-02-22 17:43:57 +0000
Message : Merge pull request #1075 from mahermanns/disambiguate-initial-commit

Disambiguate initial commit message for Guacamole recipe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial recipe template already has a specific name.
3 participants