[DO NOT MERGE] config: allow for inline to end of line comments #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, variables cannot contain commands and cannot span more than
one argument. This is due to variable replacement happening after
determining the handler and after splitting the config line into
arguments.
This changes the process to:
0. Check for empty lines and block boundaries
1. Split the arguments as before
2. Verify that the first argument is not a variable. If needed the
following occurs
a. Perform variable replacement on just the first argument
b. Join the arguments back together then split the arguments again. This is needed when the variable
contains the command and arguments for the command.
3. Determine the handler
4. If the handler is cmd_set, escape the variable name so that it does
not get replaced
5. Join the arguments back together, do variable replacement on the full
command, and split the arguments again
6. Perform any needed quote stripping or unescaping on arguments
7. Run the command handler
This allows for config snippets such as:
```
set $super bindsym Mod4
$super+a exec some-command
```
and
```
set $bg bg #ffffff solid_color
output * $bg
```
Allows for the following syntax in the config:
`command <arguments...> # the rest of this line is a comment`
Example:
`input * repeat_delay 200 # milliseconds`
Note: The space before and after the `#` is mandatory otherwise the
`#` will be seen as part of an argument (such as colors). If a `#`
is needed as it's own argument, then it can be enclosed in quotes. For
example, `bar bar-0 separator_symbol "#"`.
|
How about using something else for comments? (// or /* */) |
|
The computer scientist in me really hates this. It's such a subtle difference and leads to "# " becoming a token in the grammar (even if it's not implemented that way). |
|
This is deliberately unsupported. Consider colors, for example. |
This PR allowed comments at the end of line only if Still not sure it's a good idea. |
|
Gotcha. Still not a fan of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS BRANCHED FROM #2979 SO THAT NEEDS TO BE MERGED FIRST
Closes #3044
Allows for the following syntax in the config:
command <arguments...> # the rest of this line is a commentExample:
input * repeat_delay 200 # millisecondsNote: The space before and after the
#is mandatory otherwise the#will be seen as part of an argument (such as colors). If a#is needed as it's own argument, then it can be enclosed in quotes. For example,bar bar-0 separator_symbol "#".