Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add achievement for losing #945

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Add achievement for losing #945

merged 1 commit into from
Jan 25, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jan 2, 2023 •
edited
Loading

Test procedure

  1. Start game

    ./scripts/play.sh

  2. Observe empty achievements

  3. Select "New Game" -> "Challenges" -> "Lake crossing"

  4. turn east; move

image

image

@kostmo kostmo force-pushed the objective-prerequisites branch from 5c16451 to f988f5e Compare January 2, 2023 01:12
@kostmo kostmo mentioned this pull request Jan 2, 2023
Merged
14 tasks
@kostmo kostmo force-pushed the objective-prerequisites branch 2 times, most recently from d4fe825 to 758dd97 Compare January 2, 2023 08:19
@kostmo kostmo force-pushed the losing-achievement branch from 20f3935 to 392f717 Compare January 2, 2023 08:28
@kostmo kostmo force-pushed the objective-prerequisites branch 9 times, most recently from e4fae81 to ed8a5ac Compare January 9, 2023 04:00
@kostmo kostmo force-pushed the objective-prerequisites branch 6 times, most recently from 48bab41 to 73690cd Compare January 25, 2023 02:30
@kostmo kostmo force-pushed the losing-achievement branch from 392f717 to ddbe674 Compare January 25, 2023 08:25
@kostmo kostmo changed the base branch from objective-prerequisites to main January 25, 2023 08:41
@kostmo kostmo force-pushed the losing-achievement branch from ddbe674 to 8f095e6 Compare January 25, 2023 20:14
@kostmo kostmo marked this pull request as ready for review January 25, 2023 20:21
@kostmo kostmo requested review from byorgey and xsebek January 25, 2023 20:21
byorgey
byorgey approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so sad

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jan 25, 2023
@mergify mergify bot merged commit bf8a9a6 into main Jan 25, 2023
@mergify mergify bot deleted the losing-achievement branch January 25, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

@xsebek xsebek Awaiting requested review from xsebek

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey